test script for systemd validation#50
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
@avisinone Noticed that a few commits are duplicated in this PR (the same changes appear multiple times in the commit history). Please consider rebasing or squashing to remove the duplicates for a cleaner history. Also provide commit message. Also your run.sh is not aligned to run in the testkit suite. Refer https://github.com/smuppand/qcom-linux-testkit/blob/lib_changes/CONTRIBUTING.md |
|
Rebasing your branch on top of main will fix the license issue. Last commit (e4bda8ffad71b14d891e46ec38e1985e85883bcb) in your branch is duplicated from main branch and that causes the problem. |
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
rebase your feature branch on top of latest main.
Unify PASS/FAIL results handling to reduce redundancy.
Along with left few more comments.
mwasilew
left a comment
mwasilew
left a comment
There was a problem hiding this comment.
Please use indentation consistently and rewrite the commit message.
avisinone
force-pushed
the
platform_test
branch
2 times, most recently
from
0cb77ff to
6bbb509
Compare
| update_test_fail(){ | ||
| subtestname=$1 | ||
| msg=$2 | ||
| echo "$subtestname FAIL" >> "$res_file" |
There was a problem hiding this comment.
Can you please only add Over PASS/Fail status. Since this result file is getting parsed to get the test result, it might give wrong status?
There was a problem hiding this comment.
Hi I have changed the result logic. please check
avisinone
force-pushed
the
platform_test
branch
2 times, most recently
from
a5e8847 to
dbc44a0
Compare
| # shellcheck disable=SC1090,SC1091 | ||
| . "$TOOLS/functestlib.sh" | ||
|
|
||
| TESTNAME="systemd" |
There was a problem hiding this comment.
Better to change name of the test. As it is doing for process check here.
|
|
||
| # Call the functions | ||
| check_systemd_pid | ||
| check_systemctl_stop |
There was a problem hiding this comment.
Better move services check to different script. Any reason to club together?
|
@avisinone Can you review the errors, resolve them, and upload an updated patch? Please include a more detailed PR description, explaining why this test is necessary and outlining what it will cover. |
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
|
@avisinone please fix the checkers |
avisinone
force-pushed
the
platform_test
branch
2 times, most recently
from
c205617 to
c04548d
Compare
avisinone
force-pushed
the
platform_test
branch
from
c04548d to
99db499
Compare
Following check are implemented : systemdPID\run.sh Check systemd starts with PID 1. systemctlStartStop\run.sh Check if systemctl is able to start and stop a service. CheckFailedServices\run.sh Check for failed service on device using systemctl status. Usage Command Verified : ./run-test.sh systemPID ./run-test.sh systemctlStartStop ./run-test.sh CheckFailedServices Signed-off-by: Abhishek Sinha <abhsinh@qti.qualcomm.com>
avisinone
force-pushed
the
platform_test
branch
from
99db499 to
3ab6a37
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
Kindly include the appropriate test definitions for each test.
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
4 participants
No description provided.